Introduce EEPROM support (#166) #167
Conversation
|
I wouldn't be surprised if this is how easy it was, it looks like EEPROM just provides an alternate storage mechanism. I would defer to @per1234 on whether there are compiler directives that should block this code from being included on certain platforms. Also, I'd prefer to add unit tests of (at least some) read, write, and comparison functions just to prove that the implementation -- obvious though it is -- matches what is expected. |
|
I agree that more tests are needed, but that is what students are for! I can have them contribute the additional tests to my private repository or to a branch here. I thought that a branch here would be more realistic. So would it be appropriate to have a branch that doesn't have adequate testing yet, and then once the branch is up to par it could be merged into master? |
|
Absolutely, in CONTRIBUTING.md I describe using a branch called |
|
Thanks. I see now how to submit a PR to a branch. I'll do that... |
|
Just for git's issue-linking visibility, this was to address #166 |
First, is this really as easy as it seems? I copied EEPROM.h from here, and added lines 30-35. It seems to compile and one function gives the expected value (obviously more testing needs to be done; see below).
Is it possible to create a branch and merge this into the branch (unless you think it is okay in master)? I'd like to invite someone to add more tests and would prefer that they contribute here rather than through my fork (but that is a fine second-best alternative).